Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDPR consent management for madvertise bidder adapter #2655

Merged
merged 9 commits into from
Jun 5, 2018

Conversation

NLopezMad
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Add GDPR consent management to madvertise bidder adapter

Be sure to test the integration with your adserver using the Hello World sample page.

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NLopezMad I took a look through the changes and they seem mostly good.

There are two points on the setup I saw in the spec file that aren't correct, but they're not breaking anything (since you kept the values consistent).

The code in the adapter file is working properly based on my testing.

I'm going to approve this PR, but I'm not going to merge it yet in case you want to update the spec file. I will ensure to merge it though before the next release so it gets included.

beforeEach(function () {
let mockConfig = {
consentManagement: {
cmpApi: 'IAB',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a note more-so - the value will be iab instead of IAB.

consentManagement: {
cmpApi: 'IAB',
timeout: 1111,
allowAuctionWithoutConsent: 'cancel'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related to above, this should be a boolean value (false in this case) not the string cancel. Passing in a string here actually causes the config to the opposite value (ie true) which allows the auction to proceed without consent.

@jsnellbaker jsnellbaker merged commit 646a971 into prebid:master Jun 5, 2018
Pupis pushed a commit to adform/Prebid.js that referenced this pull request Jun 7, 2018
* New adapter madvertise

* Update madvertiseBidAdapter.js

remove aliases

* Update madvertiseBidAdapter.js

use parseSizesInput method

* fix test parseSizesInput

* fix lint parseSizesInput

* remove seeanAd feature

* remove console.log

* Add gdpr consent management to madvertise module
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
* New adapter madvertise

* Update madvertiseBidAdapter.js

remove aliases

* Update madvertiseBidAdapter.js

use parseSizesInput method

* fix test parseSizesInput

* fix lint parseSizesInput

* remove seeanAd feature

* remove console.log

* Add gdpr consent management to madvertise module
StefanWallin pushed a commit to mittmedia/Prebid.js that referenced this pull request Sep 28, 2018
* New adapter madvertise

* Update madvertiseBidAdapter.js

remove aliases

* Update madvertiseBidAdapter.js

use parseSizesInput method

* fix test parseSizesInput

* fix lint parseSizesInput

* remove seeanAd feature

* remove console.log

* Add gdpr consent management to madvertise module
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
* New adapter madvertise

* Update madvertiseBidAdapter.js

remove aliases

* Update madvertiseBidAdapter.js

use parseSizesInput method

* fix test parseSizesInput

* fix lint parseSizesInput

* remove seeanAd feature

* remove console.log

* Add gdpr consent management to madvertise module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants